BUG #12336: Fix init categorical series with scalar value #12368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream
* pydata/master: (290 commits) BUG: resample with nunique CLN: change getargspec -> signature COMPAT: invalid casting to nan TST: skip blosc tests on msgpacks if not installed API: consistency in aggregate groupby results docs: add hyperlinks to str.get_dummies TST: confirming tests for #12348 DEPR: GH10623 remove items from msgpack.encode for blocks ENH: gbq docs update COMPAT: dateutil=2.2 compat NaT.isoformat() returns 'NaT'. BUG: addtl fix for compat summary of groupby/resample with dicts DOC: add addtl docs for FloatIndexing changes in 0.18.0 TST: skip some unreliable io/data.py tests BUG: Prevent abuse of kwargs in stat functions DOC/DEPR: remove remaining occurences of mpl_style from docs (GH12190) DOC: move extractall ref point DOC: whatsnew link v0.18.0 for float_indexers DOC: some rewording of highlights DOC: missing colon ...
* pydata/master: BUG: Bug in DataFrame.set_index() with tz-aware Series
|
normally we don't need to open a new PR, just push to the same one in the future. ok for now |
| @@ -635,6 +635,10 @@ def test_fromValue(self): | |||
| self.assertEqual(dates.dtype, 'M8[ns]') | |||
| self.assertEqual(len(dates), len(self.ts)) | |||
|
|
|||
| categorical = Series(0, index=self.ts.index, dtype="category") | |||
There was a problem hiding this comment.
add the issue number as a comment (and a 1-line explanation)
Improve test, add comment
|
@jreback Sorry about opening a new PR; got confused about rebasing. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12336
Changed the tests to match the other ones in
test_fromValue.