BUG: Preserve timezone in unaligned assignments #12982
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1940,6 +1940,16 @@ def test_setitem_with_unaligned_sparse_value(self): | |||
| exp = pd.Series([1, 0, 0], name='new_column') | |||
| assert_series_equal(df['new_column'], exp) | |||
|
|
|||
| def test_setitem_with_unaligned_tz_aware_datetime_column(self): | |||
There was a problem hiding this comment.
can you also test this will .loc and a mask
e.g.
df.loc[[0,1,2],'dates'] = columns[[1,0,2]] (should be the same result)
There was a problem hiding this comment.
I've addressed comments, and travis checks pass.
jreback
added
Bug
Indexing
| @@ -428,3 +428,4 @@ Bug Fixes | |||
|
|
|||
|
|
|||
| - Bug in ``fill_value`` is ignored if the argument to a binary operator is a constant (:issue `12723`) | |||
| - Bug in ``DataFrame._santize_column`` now preserves Timezone when RHS is a Series (:issue `12981`) | |||
There was a problem hiding this comment.
say setting a column with alignment to a Series that is datetime tz-aware dtype. We don't expect readers to know about internal functions, just the outward effects.
|
minor changes. ping when green. |
| - ``pd.read_excel()`` now accepts column names associated with keyword argument ``names``(:issue:`12870`) | ||
|
|
||
|
|
||
| - Bug in ``fill_value`` is ignored if the argument to a binary operator is a constant (:issue `12723`) |
A fix for GH12981. When doing a slice assign to a DataFrame where the right-hand-side was timezone-aware datetime Series which required realignment to perform the assignment, the timezone would be stripped from the RHS on assignment.
…re_datetime_column GH12981: addressed jreback's comment
ajenkins-cargometrics
force-pushed
the
GH12981
branch
from
40b28c9 to
6689f57
Compare
Current coverage is 83.85%@@ master #12982 diff @@
==========================================
Files 136 136
Lines 49711 49711
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 41679 41683 +4
+ Misses 8032 8028 -4
Partials 0 0
|
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffA fix for #12981. When doing a slice assign to a DataFrame where the
right-hand-side was timezone-aware datetime Series which required
realignment to perform the assignment, the timezone would be stripped
from the RHS on assignment.