CLN: used np.__version__ and removed instantiation #14988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rkern and others [recommend](http://stackoverflow.com/questions/1520234/how-to-check-which-version-of-numpy-im-using) using `np.__version__` instead of `np.version`. However I realize this is pandas "internals" so there may be some reason for using `np.version` over `np.__version__`. I could not find any such reason. I also removed a duplicate `LooseVersion(_np_version)` and reused the existing `_nlv` instance.
Current coverage is 84.66% (diff: 100%)@@ master #14988 diff @@
==========================================
Files 144 144
Lines 51056 51056
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43225 43225
Misses 7831 7831
Partials 0 0
|
jorisvandenbossche
added
Clean
Compat
|
@john-a-m that's a really old link, but in any event, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rkern and others recommend using
np.__version__instead ofnp.version. However I realize this is pandas "internals" so there may be some reason for usingnp.versionovernp.__version__. I could not find any such reason. I also removed a duplicateLooseVersion(_np_version)and reused the existing_nlvinstance.nosetests .\pandas\tests\test_compat.pyand 5 tests passedgitcommand to work, butflake8 .\compat\numpy\__init__.pypasses fineseveral new features, enhancements, and performance improvementsin the v0.20.0.txt file