Skip to content

TST: test addl feather dtypes #16004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2017
Merged

TST: test addl feather dtypes #16004

merged 1 commit into from
Apr 14, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 14, 2017

No description provided.

@jreback jreback added IO Data IO issues that don't fit into a more specific label Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite labels Apr 14, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 14, 2017
jreback
jreback commented Apr 14, 2017
View reviewed changes
pandas/tests/io/test_feather.py
@@ -80,6 +79,9 @@ def test_unsupported(self):
df = pd.DataFrame({'a': pd.period_range('2013', freq='M', periods=3)})
self.check_error_on_write(df, ValueError)

df = pd.DataFrame({'a': pd.timedelta_range('1 day', periods=3)})
self.check_error_on_write(df, FeatherError)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesm this is supported in pyarrow 0.3, but testing for completeness here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test to Arrow to verify?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@jreback jreback merged commit 85a9f8c into pandas-dev:master Apr 14, 2017
@codecov
Copy link

codecov bot commented Apr 14, 2017

Codecov Report

Merging #16004 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16004   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         145      145           
  Lines       50391    50391           
=======================================
  Hits        45870    45870           
  Misses       4521     4521
Flag Coverage Δ
#multiple 88.83% <ø> (ø) ⬆️
#single 40.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9451d...c0bce7b. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 14, 2017

Codecov Report

Merging #16004 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16004   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         145      145           
  Lines       50391    50391           
=======================================
  Hits        45870    45870           
  Misses       4521     4521
Flag Coverage Δ
#multiple 88.83% <ø> (ø) ⬆️
#single 40.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9451d...c0bce7b. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 14, 2017 •
edited
Loading

Codecov Report

Merging #16004 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16004   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         145      145           
  Lines       50391    50391           
=======================================
  Hits        45870    45870           
  Misses       4521     4521
Flag Coverage Δ
#multiple 88.83% <ø> (ø) ⬆️
#single 40.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9451d...c0bce7b. Read the comment docs.

@jreback jreback mentioned this pull request Apr 16, 2017
Closed
asfgit pushed a commit to apache/arrow that referenced this pull request Apr 16, 2017
@jreback @wesm
ARROW-836: add test for pandas conversion of timedelta, currently uni…
09e6ead 
…mplemented

xref pandas-dev/pandas#16004

Author: Jeff Reback <[email protected]>

Closes #551 from jreback/timedelta and squashes the following commits:

cfd310e [Jeff Reback] TST: add test for pandas conversion of timedelta, currently unimplemented
jeffknupp pushed a commit to jeffknupp/arrow that referenced this pull request Jun 3, 2017
@jreback @jeffknupp
ARROW-836: add test for pandas conversion of timedelta, currently uni…
9b8750d 
…mplemented

xref pandas-dev/pandas#16004

Author: Jeff Reback <[email protected]>

Closes apache#551 from jreback/timedelta and squashes the following commits:

cfd310e [Jeff Reback] TST: add test for pandas conversion of timedelta, currently unimplemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm left review comments

Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions IO Data IO issues that don't fit into a more specific label Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jreback @wesm