Skip to content

BUG: Fix TypeError caused by GH13374 #17465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 10, 2017
Merged

BUG: Fix TypeError caused by GH13374 #17465

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
edb9337
Fixes a bug introduced by #13374
Sep 7, 2017
8d9ac4b
BUG: Fixed bug caused by GH13374
Sep 7, 2017
ced6fc6
CLN: PEP8 for GH17465
Sep 7, 2017
4b3d5de
Merge branch 'master' of https://github.com/pandas-dev/pandas into py…
Sep 8, 2017
4745d6d
TST: Added test for gh-13374
Sep 8, 2017
6896727
TST: remove iterator option from test
Sep 8, 2017
5a9ee56
TST: document test for gh-17465
matthax Sep 9, 2017
e9e5e97
Merge branch 'master' of https://github.com/pandas-dev/pandas into py…
matthax Sep 9, 2017
a24b96f
CLN: change code and comment to meet guidelines
matthax Sep 9, 2017
f151405
CLN: fix code format for pep8
matthax Sep 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.21.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ I/O
- Bug in :func:`read_csv` when called with a single-element list ``header`` would return a ``DataFrame`` of all NaN values (:issue:`7757`)
- Bug in :func:`read_stata` where value labels could not be read when using an iterator (:issue:`16923`)
- Bug in :func:`read_html` where import check fails when run in multiple threads (:issue:`16928`)
- Bug in :func:`read_csv` where automatic delimiter detection caused a `TypeError` to be thrown when a bad line was encountered (:issue:`13374`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use double-back-ticks around TypeError

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add:

rather than the correct error message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated both. Looks like you're going to have to manually restart the travis build though, something went wrong there and I'm not able to see any log info.


Plotting
^^^^^^^^
Expand Down
3 changes: 2 additions & 1 deletion pandas/io/parsers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2836,7 +2836,8 @@ def _rows_to_cols(self, content):
for row_num, actual_len in bad_lines:
msg = ('Expected %d fields in line %d, saw %d' %
(col_len, row_num + 1, actual_len))
if len(self.delimiter) > 1 and self.quoting != csv.QUOTE_NONE:
if self.delimiter and \
len(self.delimiter) > 1 and self.quoting != csv.QUOTE_NONE:
Copy link
Member

@gfyoung gfyoung Sep 9, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally practice for is to use parentheses around the conditionals and not to use the slash for something a little nicer to read i.e.:

if (self.delimiter and
    len(self.delimiter) > 1...)

# see gh-13374
reason = ('Error could possibly be due to quotes being '
'ignored when a multi-char delimiter is used.')
Expand Down