Skip to content

BUG: do not escape placeholder in to_latex() #18670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

toobaz
Copy link
Member

@toobaz toobaz commented Dec 6, 2017

@toobaz toobaz force-pushed the latex_placeholder_18667 branch from d9d49f8 to e81e96e Compare December 7, 2017 07:05
@codecov
Copy link

codecov bot commented Dec 7, 2017

Codecov Report

Merging #18670 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18670      +/-   ##
==========================================
- Coverage   91.59%   91.57%   -0.02%     
==========================================
  Files         153      153              
  Lines       51212    51210       -2     
==========================================
- Hits        46908    46896      -12     
- Misses       4304     4314      +10
Flag Coverage Δ
#multiple 89.43% <ø> (-0.01%) ⬇️
#single 40.67% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/format.py 96.09% <ø> (+0.07%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/util/testing.py 81.82% <0%> (-0.2%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/core/indexes/datetimes.py 95.68% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695e893...e81e96e. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 7, 2017

Codecov Report

Merging #18670 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18670      +/-   ##
==========================================
- Coverage   91.59%   91.55%   -0.04%     
==========================================
  Files         153      153              
  Lines       51212    51212              
==========================================
- Hits        46908    46888      -20     
- Misses       4304     4324      +20
Flag Coverage Δ
#multiple 89.41% <ø> (-0.03%) ⬇️
#single 40.67% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/format.py 96.09% <ø> (+0.07%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.44% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695e893...e81e96e. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Dec 8, 2017

cc @agartland
cc @syxolk
cc @MXKY

this looks reasonable, if any of you have any thoughts.

@syxolk
Copy link
Contributor

syxolk commented Dec 10, 2017

I don't see the use case. @toobaz Can you give further explanations?

@toobaz
Copy link
Member Author

toobaz commented Dec 10, 2017

I don't see the use case. @toobaz Can you give further explanations?

I gave an example in #18667, but maybe the following looks more "normal":

pd.DataFrame(-1,
             index=pd.MultiIndex.from_product([[1, 2]]*3, names=['a', 'b', 'c']),
             columns=range(2)
             ).unstack().to_latex()

@jreback jreback added this to the 0.23.0 milestone Dec 21, 2017
@jreback jreback merged commit aa67207 into pandas-dev:master Dec 21, 2017
@jreback
Copy link
Contributor

jreback commented Dec 21, 2017

thanks @toobaz

@toobaz toobaz deleted the latex_placeholder_18667 branch December 21, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious braces in output of DataFrame.to_latex() with MultiIndex columns, MultiIndex index and missing level name
4 participants