-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DOC: Update the pandas.Series.str.count() docstring (Delhi) #20154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pandas/core/strings.py
Outdated
|
||
Examples | ||
-------- | ||
Take a look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move this link to be under the flags parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea, will do
4 NaN | ||
5 0.0 | ||
6 1.0 | ||
dtype: float64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an examle with special characters like $
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I remove the note in the doc?
…under the flags param description
Codecov Report
@@ Coverage Diff @@
## master #20154 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 150 150
Lines 49156 49152 -4
==========================================
- Hits 45090 45086 -4
Misses 4066 4066
Continue to review full report at Codecov.
|
@TomAugspurger please take a look at the update |
[ci skip]
Thanks! |
Checklist for the pandas documentation sprint (ignore this if you are doing
an unrelated PR):
scripts/validate_docstrings.py <your-function-or-method>
git diff upstream/master -u -- "*.py" | flake8 --diff
python doc/make.py --single <your-function-or-method>
Please include the output of the validation script below between the "```" ticks:
As discussed in the gitter channel it was suggested to ignore kwargs for now.
Not sure what should be a part of see also here.