-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CLN: Remove PeriodIndex.tz_convert, tz_localize #21935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e53fd93
CLN: Removed tz_convert and tz_localize, fixed test. GH21781
jequinon 02e7967
Merge remote-tracking branch 'upstream/master' into PeriodIndexCleanUp
jequinon 6b2c237
Removed tz_convert, tz_localize from class doc. GH21781
jequinon f5dc5d9
Added changes to whatsnew doc
jequinon 26c8bc2
Added newline to fix style error
jequinon 2ce60ec
Removed double include causing failed build, updated api.rst
jequinon 24a166a
Removing previous api.rst changes, caused unexpected failures
jequinon 3867931
Moved whatsnew entry to Other API Changes, and removed unecessary com…
jequinon f46f848
Removed methods from api.rst again
jequinon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -747,7 +747,6 @@ def test_datetime_assignment_with_NaT_and_diff_time_units(self): | |
|
||
def test_frame_to_period(self): | ||
K = 5 | ||
from pandas.core.indexes.period import period_range | ||
|
||
dr = date_range('1/1/2000', '1/1/2001') | ||
pr = period_range('1/1/2000', '1/1/2001') | ||
|
@@ -779,10 +778,7 @@ def test_tz_convert_and_localize(self, fn): | |
|
||
# TODO: l1 should be a PeriodIndex for testing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove this comment |
||
# after GH2106 is addressed | ||
with pytest.raises(NotImplementedError): | ||
period_range('20140701', periods=1).tz_convert('UTC') | ||
with pytest.raises(NotImplementedError): | ||
period_range('20140701', periods=1).tz_localize('UTC') | ||
|
||
# l1 = period_range('20140701', periods=5, freq='D') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this comment out as well |
||
l1 = date_range('20140701', periods=5, freq='D') | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should go in the
Other API Changes
section. We generally reserve this area for actual deprecations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, gotcha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I tried to document the changes made in api.rst, but removing the methods caused a bunch of errors in the build. Do you know what is causing that? Do I need to build the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure ATM. If there's anything to remove in
api.rst
(or any of the.rst
files), it would be reference to the methods that you just removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move to Other API canges, otherwise lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping when this is moved