Skip to content

BUG GH23451 Allow setting date in string index for Series #23495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2018
+11 −1
Merged

BUG GH23451 Allow setting date in string index for Series #23495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d03b80
BUG-23451 Allow setting date in string index for Series
JustinZhengBC Nov 4, 2018
ad7c8ef
BUG-23451 Add whatsnew and other requested changes
JustinZhengBC Nov 4, 2018
70a0725
BUG-23451 Make requested changes
JustinZhengBC Nov 5, 2018
12d2f8a
Merge branch 'master' of https://github.com/pandas-dev/pandas into BU…
JustinZhengBC Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,9 @@ def _set_with(self, key, value):
except Exception:
pass

if isinstance(key, str):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might be able to make this is_scalar

key = [key]

if not isinstance(key, (list, Series, np.ndarray, Series)):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Series is here twice :< can you remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be an elseif

try:
key = list(key)
Expand Down
6 changes: 6 additions & 0 deletions pandas/tests/series/test_datetime_values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,3 +548,9 @@ def test_minmax_nat_series(self, nat):
def test_minmax_nat_dataframe(self, nat):
assert nat.min()[0] is pd.NaT
assert nat.max()[0] is pd.NaT

def test_set_dt_with_string_index(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to test_setitem_with_string_index

from datetime import date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imports go at the top

x = pd.Series([1, 2, 3], index=['Date', 'b', 'other'])
x.Date = date.today()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try this both as (parametrize)
x.Date = and x['Date'] =

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to figure out how to parametrize both these cases, as "Date" is being used in different contexts. What would be the variable(s) I parametrize and how would I use it with x to cover both cases?

assert x.Date == date.today()