-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Array api docs #24626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array api docs #24626
Conversation
Datetimelike Properties | ||
----------------------- | ||
~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were all moved down one level. The TOC is now
Accessors
- dt
- str
- cat
- sparse
Rather than having them all at the top-level of this section.
Codecov Report
@@ Coverage Diff @@
## master #24626 +/- ##
===========================================
- Coverage 92.38% 43% -49.38%
===========================================
Files 166 166
Lines 52395 52395
===========================================
- Hits 48403 22534 -25869
- Misses 3992 29861 +25869
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24626 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 166 166
Lines 52395 52395
=======================================
Hits 48403 48403
Misses 3992 3992
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, better organized this way. Didn't review with great detail, but looks good.
I just don't quite understand the hierarchy in arrays.rst
. Seems to me that Datetime Data
should be under Pandas Arrays
and not at the same level. May be I'm just not understanding it well.
Also, I tried to be consistent with the blank lines when I splitted api.rst
, and I used:
A title
-------
Not a blank line between the ----- line and this.
Not really important, but in this PR some times blank lines are used, and some times are not.
You're correct about the heading levels. I'll fix those. |
thanks! |
Closes
#24066
cc @datapythonista @jorisvandenbossche there are a few closely related changes here.
api/arrays.rst
pd.array
to api/arrays.rstI have quite a few warnings to cleanup, but wanted a +1 on the general reorganization before putting more time into it.