-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DOC: Fix encoding of docstring validation for Windows #25466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
639302e
52ad76f
350fa92
e05aa8b
60d9df0
1a4fe4f
ff4076e
0fd3d99
9fe7fbc
70ee72a
5f1d78a
175a86f
645ab84
a9b09e3
5edb1e8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1052,6 +1052,12 @@ def test_raises_for_invalid_attribute_name(self, invalid_name): | |
with pytest.raises(AttributeError, match=msg): | ||
validate_docstrings.Docstring(invalid_name) | ||
|
||
@pytest.mark.parametrize('name', [ | ||
'pandas.Series.str.isdecimal', 'pandas.Series.str.islower']) | ||
def test_encode_content_write_to_file(self, name): # GH25466 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This comment should be on the next line. @kpapdac if you want to fix up otherwise can clean up before merging There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, I'm sorry, you said that above but I didn't get it..I'll fix it. |
||
docstr = validate_docstrings.Docstring(name).validate_pep8() | ||
WillAyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
assert len(list(docstr)) == 0 | ||
WillAyd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
class TestMainFunction: | ||
def test_exit_status_for_validate_one(self, monkeypatch): | ||
|
Uh oh!
There was an error while loading. Please reload this page.