Skip to content

CLN: Unused imports in tslibs #26168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2019
Merged

CLN: Unused imports in tslibs #26168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc9249
CLN: tslib cython imports
Apr 20, 2019
2cfdab1
fix import and put back issue reference
Apr 21, 2019
2c5688c
Fix more imports
Apr 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pandas/_libs/tslibs/c_timestamp.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ cimport numpy as cnp
from numpy cimport int64_t, int8_t
cnp.import_array()

from dateutil.tz import tzutc

from cpython.datetime cimport (datetime,
PyDateTime_Check, PyDelta_Check,
PyDateTime_IMPORT)
Expand All @@ -38,9 +36,9 @@ from pandas._libs.tslibs.fields import get_start_end_field, get_date_name_field
from pandas._libs.tslibs.nattype cimport c_NaT as NaT
from pandas._libs.tslibs.np_datetime import OutOfBoundsDatetime
from pandas._libs.tslibs.np_datetime cimport (
reverse_ops, cmp_scalar, npy_datetimestruct, dt64_to_dtstruct)
reverse_ops, cmp_scalar)
from pandas._libs.tslibs.timezones cimport (
get_timezone, get_utcoffset, is_utc, tz_compare)
get_timezone, is_utc, tz_compare)
from pandas._libs.tslibs.timezones import UTC
from pandas._libs.tslibs.tzconversion cimport tz_convert_single

Expand Down Expand Up @@ -381,5 +379,5 @@ cdef class _Timestamp(datetime):

def timestamp(self):
"""Return POSIX timestamp as float."""
# py27 compat, see GH#17329
# Note: tz-aware Timestamps will return a UTC-like timestamp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping the issue reference would be helpful. It is for naive timestamp that we don’t match the stdlib.

return round(self.value / 1e9, 6)
9 changes: 3 additions & 6 deletions pandas/_libs/tslibs/conversion.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,20 @@ import cython

import numpy as np
cimport numpy as cnp
from numpy cimport uint8_t, int64_t, int32_t, intp_t, ndarray
from numpy cimport int64_t, int32_t, intp_t, ndarray
cnp.import_array()

import pytz
from dateutil.tz import tzutc

# stdlib datetime imports
from datetime import time as datetime_time
from cpython.datetime cimport (datetime, tzinfo,
PyDateTime_Check, PyDate_Check,
PyDateTime_IMPORT, PyDelta_Check)
PyDateTime_IMPORT)
PyDateTime_IMPORT

from pandas._libs.tslibs.c_timestamp cimport _Timestamp

from pandas._libs.tslibs.ccalendar import DAY_SECONDS, HOUR_SECONDS

from pandas._libs.tslibs.np_datetime cimport (
check_dts_bounds, npy_datetimestruct, pandas_datetime_to_datetimestruct,
_string_to_dts, npy_datetime, dt64_to_dtstruct, dtstruct_to_dt64,
Expand All @@ -42,7 +39,7 @@ from pandas._libs.tslibs.nattype cimport (
NPY_NAT, checknull_with_nat, c_NaT as NaT)

from pandas._libs.tslibs.tzconversion import (
tz_localize_to_utc, tz_convert, tz_convert_single)
tz_localize_to_utc, tz_convert_single)
from pandas._libs.tslibs.tzconversion cimport _tz_convert_tzlocal_utc

# ----------------------------------------------------------------------
Expand Down
4 changes: 1 addition & 3 deletions pandas/_libs/tslibs/timedeltas.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import collections
import textwrap
import warnings

import sys

import cython

from cpython cimport Py_NE, Py_EQ, PyObject_RichCompare
Expand All @@ -14,7 +12,7 @@ cimport numpy as cnp
from numpy cimport int64_t
cnp.import_array()

from cpython.datetime cimport (datetime, timedelta,
from cpython.datetime cimport (timedelta,
PyDateTime_Check, PyDelta_Check,
PyDateTime_IMPORT)
PyDateTime_IMPORT
Expand Down
1 change: 0 additions & 1 deletion pandas/_libs/tslibs/timestamps.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ from pandas._libs.tslibs.conversion import normalize_i8_timestamps
from pandas._libs.tslibs.conversion cimport (
_TSObject, convert_to_tsobject,
convert_datetime_to_tsobject)
from pandas._libs.tslibs.fields import get_start_end_field, get_date_name_field
from pandas._libs.tslibs.nattype cimport NPY_NAT, c_NaT as NaT
from pandas._libs.tslibs.np_datetime cimport (
check_dts_bounds, npy_datetimestruct, dt64_to_dtstruct)
Expand Down