Skip to content

DOC removed unnecessary use of parameter in example rename function call #26250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KatemaNL
Copy link
Contributor

@KatemaNL KatemaNL commented Apr 30, 2019

removed unnecessary (and misleading) use of index parameter in docstring example function call of rename function

xref #26248

  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

removed unnecessary (and misleading) use of index parameter in docstring example function call of rename function
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #26250 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26250      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52384    52384              
==========================================
- Hits        48184    48180       -4     
- Misses       4200     4204       +4
Flag Coverage Δ
#multiple 90.52% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 96.9% <ø> (-0.12%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eff627...888a8f3. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #26250 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26250      +/-   ##
==========================================
- Coverage   91.98%   91.98%   -0.01%     
==========================================
  Files         175      175              
  Lines       52384    52374      -10     
==========================================
- Hits        48184    48174      -10     
  Misses       4200     4200
Flag Coverage Δ
#multiple 90.53% <ø> (ø) ⬆️
#single 40.72% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 96.9% <ø> (-0.12%) ⬇️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/base.py 97.98% <0%> (-0.22%) ⬇️
pandas/io/excel/_util.py 87.32% <0%> (-0.18%) ⬇️
pandas/util/testing.py 90.61% <0%> (-0.11%) ⬇️
pandas/core/reshape/pivot.py 96.52% <0%> (-0.02%) ⬇️
pandas/core/indexes/range.py 97.96% <0%> (-0.01%) ⬇️
pandas/io/pytables.py 90.22% <0%> (-0.01%) ⬇️
pandas/core/strings.py 98.86% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eff627...6484086. Read the comment docs.

@mroeschke mroeschke added the Docs label Apr 30, 2019
added an example for using index parameter only
added an example for casting the index type
@pep8speaks
Copy link

pep8speaks commented May 1, 2019

Hello @KatemaNL! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-05-06 17:25:08 UTC

@jreback jreback added this to the 0.25.0 milestone May 7, 2019
@jreback
Copy link
Contributor

jreback commented May 7, 2019

lgtm. @mroeschke

@mroeschke mroeschke merged commit 749f456 into pandas-dev:master May 7, 2019
@mroeschke
Copy link
Member

Thanks @KatemaNL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants