Skip to content

Correction (and clarification) to EWMA doc #26422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2019
Merged

Correction (and clarification) to EWMA doc #26422

merged 3 commits into from
May 18, 2019

Conversation

jamesoliverh
Copy link
Contributor

@jamesoliverh jamesoliverh commented May 16, 2019

Correct adjust=True to adjust=False in line 889 of the documentation (discussing EWMA).
Also propose minor clarifications in demonstration that two variants (adjust=False and adjust=True) are equivalent for infinite series (lines 868 and 887-893).

Closes #24814

Correct ``adjust=True`` to ``adjust=False`` in line 889 of the documentation (discussing EWMA). 
Also propose minor clarifications in demonstration that two variants (adjust=False and adjust=True) are equivalent for infinite series (lines 868 and 887-893).
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #26422 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26422      +/-   ##
==========================================
- Coverage   91.69%   91.69%   -0.01%     
==========================================
  Files         174      174              
  Lines       50741    50741              
==========================================
- Hits        46529    46525       -4     
- Misses       4212     4216       +4
Flag Coverage Δ
#multiple 90.19% <ø> (ø) ⬆️
#single 41.16% <ø> (-0.18%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421ae9d...6c7e368. Read the comment docs.

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #26422 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26422      +/-   ##
==========================================
+ Coverage   91.69%   91.72%   +0.02%     
==========================================
  Files         174      174              
  Lines       50741    50745       +4     
==========================================
+ Hits        46529    46547      +18     
+ Misses       4212     4198      -14
Flag Coverage Δ
#multiple 90.23% <ø> (+0.03%) ⬆️
#single 41.69% <ø> (+0.36%) ⬆️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 97.02% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.6% <0%> (-0.11%) ⬇️
pandas/core/base.py 97.99% <0%> (-0.01%) ⬇️
pandas/tseries/offsets.py 96.69% <0%> (-0.01%) ⬇️
pandas/core/reshape/reshape.py 99.56% <0%> (ø) ⬆️
pandas/io/pytables.py 90.22% <0%> (ø) ⬆️
pandas/core/window.py 96.41% <0%> (ø) ⬆️
pandas/core/reshape/merge.py 94.47% <0%> (ø) ⬆️
pandas/core/internals/blocks.py 94.08% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 421ae9d...1d196a6. Read the comment docs.

@gfyoung gfyoung added Docs Window rolling, ewma, expanding labels May 18, 2019
@gfyoung gfyoung requested a review from jreback May 18, 2019 00:52
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback jreback added this to the 0.25.0 milestone May 18, 2019
@jreback jreback merged commit 3f417b8 into pandas-dev:master May 18, 2019
@jreback
Copy link
Contributor

jreback commented May 18, 2019

thanks @jamesoliverh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas EWMA documentation possible error
3 participants