-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Correction (and clarification) to EWMA doc #26422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Correct ``adjust=True`` to ``adjust=False`` in line 889 of the documentation (discussing EWMA). Also propose minor clarifications in demonstration that two variants (adjust=False and adjust=True) are equivalent for infinite series (lines 868 and 887-893).
Codecov Report
@@ Coverage Diff @@
## master #26422 +/- ##
==========================================
- Coverage 91.69% 91.69% -0.01%
==========================================
Files 174 174
Lines 50741 50741
==========================================
- Hits 46529 46525 -4
- Misses 4212 4216 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26422 +/- ##
==========================================
+ Coverage 91.69% 91.72% +0.02%
==========================================
Files 174 174
Lines 50741 50745 +4
==========================================
+ Hits 46529 46547 +18
+ Misses 4212 4198 -14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jreback
thanks @jamesoliverh |
Correct
adjust=True
toadjust=False
in line 889 of the documentation (discussing EWMA).Also propose minor clarifications in demonstration that two variants (adjust=False and adjust=True) are equivalent for infinite series (lines 868 and 887-893).
Closes #24814