-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: fixes formatted value error for missing sheet (#27676) #27677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WillAyd
merged 21 commits into
pandas-dev:master
from
JasperVanDenBosch:fix-odfreader-sheetname-missing
Oct 25, 2019
Merged
Changes from 16 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c25f93b
BUG: fixes formatted value error for missing sheet
JasperVanDenBosch 6665fdb
added reference to bug fix for #27676 in whats new
JasperVanDenBosch c83c7c9
TST: Add test for read_excel with odf engine and nonexistent sheetname
JasperVanDenBosch 406f1a0
CLN: black fix in test_odf
JasperVanDenBosch 90897c5
TST: sheet_name test now in test_readers
JasperVanDenBosch a4efca0
TST: test_nonexistent_sheetname_raises required read_ext param
JasperVanDenBosch 4d54e3a
Merge remote-tracking branch 'upstream/master' into ilogue-fix-odfrea…
TomAugspurger e93b25a
review comments
TomAugspurger 1c2fc81
moved odf reader error message test back to odf tests
JasperVanDenBosch 2bfb709
CLN: missing blank line
JasperVanDenBosch af96eef
Merge branch 'master' into fix-odfreader-sheetname-missing
JasperVanDenBosch c149675
Merge branch 'master' into fix-odfreader-sheetname-missing
JasperVanDenBosch bec56d9
reverted changes to v0.25.1 whatsnew
JasperVanDenBosch a93b355
added line for #27676 in whatsnew 0.25.2
JasperVanDenBosch c45ffb3
[TST] fixed odf unittest
JasperVanDenBosch 589cbb1
[TST]: odf tests: hardcoded blank workbook extension as .ods
JasperVanDenBosch 56cc92d
moved whatsnew entry to 1.0
JasperVanDenBosch 669221d
Merge branch 'master' into fix-odfreader-sheetname-missing
JasperVanDenBosch 5e92329
Merge branch 'master' into fix-odfreader-sheetname-missing
JasperVanDenBosch 04fb46b
Removed whatsnew 1.0 entry for #26838 from merged master
JasperVanDenBosch 3d135fb
Update v0.25.2.rst
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to 1.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done