-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: fixes formatted value error for missing sheet (#27676) #27677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 14 commits
c25f93b
6665fdb
c83c7c9
406f1a0
90897c5
a4efca0
4d54e3a
e93b25a
1c2fc81
2bfb709
af96eef
c149675
bec56d9
a93b355
c45ffb3
589cbb1
56cc92d
669221d
5e92329
04fb46b
3d135fb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,3 +36,11 @@ def test_read_writer_table(): | |
result = pd.read_excel("writertable.odt", "Table1", index_col=0) | ||
|
||
tm.assert_frame_equal(result, expected) | ||
|
||
|
||
def test_nonexistent_sheetname_raises(self, read_ext): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The use of If you remove I think should turn green There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be done in c45ffb3 |
||
# GH-27676 | ||
# Specifying a non-existent sheet_name parameter should throw an error | ||
# with the sheet name. | ||
with pytest.raises(ValueError, match="sheet xyz not found"): | ||
pd.read_excel("blank" + read_ext, sheet_name="xyz") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to 1.0.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done