Skip to content

BUG: Exception when calling pandas.isnull() with a pandas type object #27989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

pradeepb2505
Copy link

@pradeepb2505 pradeepb2505 commented Aug 18, 2019

@pep8speaks
Copy link

pep8speaks commented Aug 18, 2019

Hello @pradeepb2505! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 131:22: E231 missing whitespace after ','

Line 5:1: E302 expected 2 blank lines, found 1
Line 6:1: W191 indentation contains tabs
Line 6:1: W293 blank line contains whitespace
Line 7:1: W191 indentation contains tabs
Line 7:2: E117 over-indented
Line 8:1: W191 indentation contains tabs
Line 8:3: E117 over-indented
Line 8:19: E231 missing whitespace after ','
Line 8:21: E231 missing whitespace after ','
Line 8:23: E231 missing whitespace after ','
Line 9:1: W191 indentation contains tabs
Line 10:1: W191 indentation contains tabs
Line 10:23: E225 missing whitespace around operator
Line 10:23: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 10:30: E231 missing whitespace after ','
Line 12:1: W191 indentation contains tabs
Line 13:1: W191 indentation contains tabs
Line 13:3: E117 over-indented
Line 13:30: E231 missing whitespace after ','
Line 13:32: E231 missing whitespace after ','
Line 13:34: E231 missing whitespace after ','
Line 14:1: W191 indentation contains tabs
Line 15:1: W191 indentation contains tabs
Line 15:23: E225 missing whitespace around operator
Line 15:23: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 15:30: E231 missing whitespace after ','
Line 19:20: W292 no newline at end of file

Comment last updated at 2019-08-18 16:37:34 UTC

@pradeepb2505 pradeepb2505 changed the title Solved issue #27482 Solved issue 27482 Aug 18, 2019
@jbrockmendel
Copy link
Member

For any bugfix PR, you'll need to add a test for the fixed behavior in pandas/tests/

@datapythonista datapythonista changed the title Solved issue 27482 BUG: Exception when calling pandas.isnull() with a pandas type object Aug 19, 2019
@datapythonista datapythonista added Bug Error Reporting Incorrect or improved errors from pandas Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Aug 19, 2019
@datapythonista
Copy link
Member

Thanks @pradeepb2505, besides adding the test, you'll have to run the two missing points in the checklist in the description. Thanks!

@TomAugspurger
Copy link
Contributor

Sorry @pradeepb2505, this was fixed by #27664.

Let us know if you want help finding another issue to work on.

@pradeepb2505
Copy link
Author

@TomAugspurger thank you for the information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error Reporting Incorrect or improved errors from pandas Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pd.isnull() raises AttributeError on Pandas type objects
5 participants