BUG: Fixed bug where Series.append raised TypeError with tuple of Series #28416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| to_concat = [self] + to_append | ||
| elif isinstance(to_append, tuple): | ||
| to_concat = [self] + list(to_append) |
There was a problem hiding this comment.
could just do this on line 2733
|
needs a test for the fixed bug |
|
Hmm looks like we have two PRs for this: #28412 (review). The other PR has a test. |
|
Yea thanks a lot for the PR @rohitkg98 but the other one came in a little earlier to solve this one. We have a ton of other open issues though, so would gladly welcome contribution on any others |
|
You're welcome! I am a newbie, this was my first pull request. I will
continue to try and contribute better quality code. Thank you for the
acknowledgement.
Regards,
Kaushal Rohit
…On Fri, Sep 13, 2019, 6:37 AM William Ayd ***@***.***> wrote:
Yea thanks a lot for the PR @rohitkg98 <https://github.com/rohitkg98> but
the other one came in a little earlier to solve this one. We have a ton of
other open issues though, so would gladly welcome contribution on any others
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28416?email_source=notifications&email_token=AFQ7KS3HW6KDRM273ZPKRDDQJLRU5A5CNFSM4IWG7WHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6TV2NI#issuecomment-531062069>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFQ7KS6MSWVPGD5DJM2EGULQJLRU5ANCNFSM4IWG7WHA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff