Skip to content

TST: Remove maybe_promote tests for iNaT as an NA value #28775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2019

Conversation

jbrockmendel
Copy link
Member

These are left over from a time when maybe_promote treated iNaT as an NA value, which we stopped doing because it is ambiguous.

Removes 22 xfails (leaving 317 in this file)

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite labels Oct 5, 2019
@jreback jreback added this to the 1.0 milestone Oct 5, 2019
@jreback jreback merged commit b96f320 into pandas-dev:master Oct 5, 2019
@jreback
Copy link
Contributor

jreback commented Oct 5, 2019

cool

@jbrockmendel jbrockmendel deleted the maybe_promote_inat branch October 6, 2019 13:40
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants