-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: Appending empty list to DataFrame #28769 #28834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8153381
BUG: Appending empty list to DataFrame #28769
asishm af5f8b2
add empty list into it's own condition
asishm 93f297c
Update doc/source/whatsnew/v1.0.0.rst
asishm bfcb20e
add check for new object
asishm 2c4d405
remove copy
asishm 9ecaeed
pep8
asishm 2789073
merge master
asishm 12ecc1f
fix tests
asishm 8eb4ec7
Merge branch 'master' into append_empty_bugfix
asishm 7a5856b
Merge remote-tracking branch 'upstream/master' into append_empty_bugfix
asishm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,6 +128,20 @@ def test_concat_tuple_keys(self): | |
) | ||
tm.assert_frame_equal(results, expected) | ||
|
||
def test_append_empty_list(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you parameterize with empty list, tuple, np.ndarray There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jreback Please see the reply in the other comment (#28834 (comment)) |
||
# GH 28769 | ||
df = DataFrame() | ||
result = df.append([]) | ||
expected = df | ||
tm.assert_frame_equal(result, expected) | ||
assert result is not df | ||
|
||
df = DataFrame(np.random.randn(5, 4), columns=["foo", "bar", "baz", "qux"]) | ||
result = df.append([]) | ||
expected = df | ||
tm.assert_frame_equal(result, expected) | ||
assert result is not df # .append() should return a new object | ||
|
||
def test_append_series_dict(self): | ||
df = DataFrame(np.random.randn(5, 4), columns=["foo", "bar", "baz", "qux"]) | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.