Skip to content

Improve performance of equality comparison between a simple Index and a MultiIndex #29134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 5, 2019
Merged

Improve performance of equality comparison between a simple Index and a MultiIndex #29134

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8c9f29b
PERF: Check shape compatibility before full array equivalence
tlaytongoogle Oct 17, 2019
606bb8e
Allow d-level MultiIndex to be equivalent to d-tuple object Index
tlaytongoogle Oct 17, 2019
c3235c0
Use is_object_type() instead of Index.is_object()
tlaytongoogle Oct 17, 2019
f52b992
Revert length comparison to previous position
tlaytongoogle Oct 17, 2019
61ec0f2
PERF: Check shape compatibility before full array equivalence
tlaytongoogle Oct 17, 2019
b2b6f05
Add whatsnew entry for issue #29134
tlaytongoogle Oct 21, 2019
bde3d38
Invoke is_object_dtype() on dtype attribute
tlaytongoogle Dec 2, 2019
c76005e
Add ASV benchmarks for index-multiindex equality
tlaytongoogle Dec 3, 2019
b27e30f
Adjust lines to within size limit
tlaytongoogle Dec 3, 2019
cbd71f4
Merge branch 'master' into master
tlaytongoogle Dec 3, 2019
767d96d
Fix formatting
tlaytongoogle Dec 3, 2019
8245a10
Merge to repair upstream test failure
tlaytongoogle Dec 4, 2019
5310fff
Reduce runtime of ASV benchmarks
tlaytongoogle Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4333,6 +4333,11 @@ def equals(self, other):
# if other is not object, use other's logic for coercion
return other.equals(self)

if isinstance(other, ABCMultiIndex):
if not is_object_dtype(self): # d-level MultiIndex can equal d-tuple Index
if self.nlevels != other.nlevels:
return False

return array_equivalent(
com.values_from_object(self), com.values_from_object(other)
)
Expand Down
4 changes: 4 additions & 0 deletions pandas/core/indexes/multi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3147,6 +3147,10 @@ def equals(self, other):
return False

if not isinstance(other, MultiIndex):
if not is_object_dtype(other): # d-level MultiIndex can equal d-tuple Index
if self.nlevels != other.nlevels:
return False

other_vals = com.values_from_object(ensure_index(other))
return array_equivalent(self._ndarray_values, other_vals)

Expand Down