Adding more documentation for upsampling with replacement and error m…

[CooperData]

…essage in case replacement is set to False

• closes Dataframe.sample() isn't validating frac #27451
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[pep8speaks]

Hello @CooperData! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-07 23:38:05 UTC

[jreback]

go ahead and add a whatsnew note, bugfix in 1.0 in the numeric section; you can say that a better error message will be raised when frac > 1 and replace=True

[jreback]

lgtm. ping on green.

[CooperData]

@jreback - CI failed but I am not sure what it's causing the issue. I was able to run the tests while I was at the sprint. But dont know if I did anything that is creating the issue.

[jreback]

see https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=20307&view=logs&jobId=d6a36677-9147-59f9-684d-001fc5c44c5e

looks like just some extra white space

fix and push up if u can

[CooperData]

I added a dot at the end of the raised error as per other errors I saw. I also changed the test msg checked to match the error raised so it's 2 lines as well. I was not able to understand what exactly the error was.

[jreback]

thanks @CooperData

[CooperData]

@jreback, I am going through the messages on the build for the last push, and it seems it's failing because the function inside that is supposed to give the error message is failing. In other words, the desired behavior is to make the test fail but compare the error message, not to make the test fail itself.

[CooperData]

The failures seem associated with something else that I did not change: errors

[jreback]

thanks @CooperData !