-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
DEPR: remove Index fastpath kwarg #29725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
01f9cbf
ecdba48
541bd02
2beef6c
c258a77
d6fa489
c0ed56f
cd61136
89e6912
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -259,14 +259,7 @@ def _outer_indexer(self, left, right): | |
# Constructors | ||
|
||
def __new__( | ||
cls, | ||
data=None, | ||
dtype=None, | ||
copy=False, | ||
name=None, | ||
fastpath=None, | ||
tupleize_cols=True, | ||
**kwargs, | ||
cls, data=None, dtype=None, copy=False, name=None, tupleize_cols=True, **kwargs, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure how we historically handle but unfortunate this accepts kwargs - I suppose if someone keeps supplying There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed |
||
) -> "Index": | ||
|
||
from .range import RangeIndex | ||
|
@@ -278,16 +271,6 @@ def __new__( | |
if name is None and hasattr(data, "name"): | ||
name = data.name | ||
|
||
if fastpath is not None: | ||
warnings.warn( | ||
"The 'fastpath' keyword is deprecated, and will be " | ||
"removed in a future version.", | ||
FutureWarning, | ||
stacklevel=2, | ||
) | ||
if fastpath: | ||
return cls._simple_new(data, name) | ||
|
||
if isinstance(data, ABCPandasArray): | ||
# ensure users don't accidentally put a PandasArray in an index. | ||
data = data.to_numpy() | ||
|
@@ -1132,19 +1115,6 @@ def _summary(self, name=None): | |
name = type(self).__name__ | ||
return f"{name}: {len(self)} entries{index_summary}" | ||
|
||
def summary(self, name=None): | ||
""" | ||
Return a summarized representation. | ||
|
||
.. deprecated:: 0.23.0 | ||
""" | ||
warnings.warn( | ||
"'summary' is deprecated and will be removed in a future version.", | ||
FutureWarning, | ||
stacklevel=2, | ||
) | ||
return self._summary(name) | ||
|
||
# -------------------------------------------------------------------- | ||
# Conversion Methods | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this was what I had in mind for whatsnew placing.