Skip to content

CLN: changed .format to fstring in pandas/io/formats/csvs.py #30425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 24, 2019

Conversation

sardonick
Copy link
Contributor

@sardonick sardonick commented Dec 23, 2019

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

#29547

My first contribution.

@jreback jreback added the Code Style Code style, linting, code_checks label Dec 23, 2019
@alimcmaster1
Copy link
Member

Test failures related to @MomIsBestFriend comments above:

 with pytest.raises(ValueError, match=msg):
>               float_frame.to_csv(path, header=["AA", "X"])
E               AssertionError: Pattern 'Writing 4 cols but got 2 aliases' not found in 'Writing 4 cols but got 

@alimcmaster1
Copy link
Member

Issue to ref here is #29547

@pep8speaks
Copy link

pep8speaks commented Dec 24, 2019

Hello @sardonick! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-24 01:38:19 UTC

@jreback jreback added this to the 1.0 milestone Dec 24, 2019
@jreback jreback merged commit a987c54 into pandas-dev:master Dec 24, 2019
@jreback
Copy link
Contributor

jreback commented Dec 24, 2019

thanks @sardonick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants