REF/BUG: DTA/TDA/PA comparison ops inconsistencies #30637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Period
jreback
approved these changes
Jan 3, 2020
WillAyd
approved these changes
Jan 3, 2020
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will take a couple of steps to get these three methods to all behave the same. Following that we can move to share code between them.
This came up when trying to make the indexes dispatch
searchsortedand it turns out that the DTI/TDI/PI searchsorted methods are not consistent with their DTA/TDA/PA counterparts. The fix is to have shared validation/casting methods, which should in turn be consistent with the comparison ops.