Skip to content

REF: share comparison methods between ExtensionIndex subclasses #30817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2020
Merged

REF: share comparison methods between ExtensionIndex subclasses #30817

merged 4 commits into from
Jan 9, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jbrockmendel
Copy link
Member Author

@jschendel looks like Interval comparisons are failing here. Is that the expected behavior?

@jschendel
Copy link
Member

Yeah, inequalities haven't been implemented yet, and look a little buggy at the Interval level.

@jreback jreback added ExtensionArray Extending pandas with custom dtypes or arrays. Index Related to the Index class or subclasses labels Jan 9, 2020
@jreback jreback added this to the 1.0 milestone Jan 9, 2020
@jreback jreback merged commit 23c1425 into pandas-dev:master Jan 9, 2020
@jreback
Copy link
Contributor

jreback commented Jan 9, 2020

thanks

@jbrockmendel jbrockmendel deleted the ref-share-cmp branch January 9, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Index Related to the Index class or subclasses
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jschendel @jreback