Skip to content

DOC: Fixed example section in pandas/core/dtypes/*.py #31451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 10, 2020
Merged

DOC: Fixed example section in pandas/core/dtypes/*.py #31451

merged 6 commits into from
Feb 10, 2020

Conversation

ShaharNaveh
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added this to the 1.1 milestone Jan 31, 2020
WillAyd
WillAyd requested changes Jan 31, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at these. Is doctest picking these up?

@ShaharNaveh ShaharNaveh requested a review from WillAyd February 1, 2020 10:26
@jreback
Copy link
Contributor

jreback commented Feb 1, 2020

@datapythonista @jorisvandenbossche if any comments

WillAyd
WillAyd approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. If there’s a way for doctest to pick these up and automatically check would be all for it in a follow up

jorisvandenbossche
jorisvandenbossche requested changes Feb 3, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MomIsBestFriend can you add those files to the "DOCTESTS" section in code_checks.sh? (or are not yet all docstrings of the files passing?)

@ShaharNaveh
Copy link
Member Author

@MomIsBestFriend can you add those files to the "DOCTESTS" section in code_checks.sh? (or are not yet all docstrings of the files passing?)

@jorisvandenbossche Yes, all the doctests are now passing, I have added it in 2a330b4

jreback
jreback approved these changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche merged commit 4ab7bb4 into pandas-dev:master Feb 10, 2020
@jorisvandenbossche
Copy link
Member

Thanks!

@ShaharNaveh ShaharNaveh deleted the DOC-fix-pytest branch March 19, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@ShaharNaveh @jreback @jorisvandenbossche @WillAyd @jbrockmendel