Some code cleanups #31792
Some code cleanups #31792
Conversation
|
|
||
| shape = " x ".join(pprint_thing(s) for s in self.shape) | ||
| result = ( | ||
| f"{name}: {pprint_thing(self.mgr_locs.indexer)}, " |
There was a problem hiding this comment.
AFICT the pprint_thing is just a python2 thing.
@jbrockmendel can you please confirm or explain what it is?
There was a problem hiding this comment.
Yes - shouldn’t be needed now py3 only. Worth checking though
There was a problem hiding this comment.
can you please confirm or explain what it is?
I think it might matter if you were dealing with nested objects, but for these i think it is just a leftover py2 thing
|
Seems to have introduced a few test failures? Generally looks good |
| if isinstance(slicer, tuple): | ||
| axis0_slicer = slicer[0] | ||
| else: | ||
| axis0_slicer = slicer |
There was a problem hiding this comment.
i tend to like this version because i can see in coverage output whether both cases are reached
There was a problem hiding this comment.
@jbrockmendel I can see your point, I like the one-liner version because it's making less noise (IMO).
Anyway I am fine with reverting this one and also others.
Can we open a discussion for it (in a separate issue)? so we will put it in Pandas code style guide
There was a problem hiding this comment.
@jbrockmendel are you sticking on this one? +/- 0 on this.
ShaharNaveh
force-pushed
the
OCD-COLLECTION
branch
from
85acf78 to
43db70c
Compare
|
Thanks @MomIsBestFriend |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff