-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: fix infer_dtype for StringDtype #31877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
a20f41c
fcaddd3
a928d0b
f04932c
92b0083
1d7a1d3
45947a8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -246,3 +246,10 @@ def test_convert_dtypes(self, data, maindtype, params, answerdict): | |
|
||
# Make sure original not changed | ||
tm.assert_series_equal(series, copy) | ||
|
||
def test_convert_string_dtype(self): | ||
# https://github.com/pandas-dev/pandas/issues/31731 -> converting columns | ||
# that are already string dtype | ||
df = pd.DataFrame({"A": ["a", "b", "c"], "B": ["ä", "ö", "ü"]}, dtype="string") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you parameterize using the nulls_fixture (and no null as you have now) as well There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we may want to have a null_fixture_for_strings e.g. [None, np.nan, pd.NA] There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no need to parametrize for nulls here, I think. I am creating this with dtype string, and once you have that dtype, there is no difference for different nulls. So it would be testing construction with different nulls, which isn't the goal here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are there other tests that convert_dtypes on strings with nulls? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. convert_dtypes doesn't care about nulls or not if the dtype is already "string". But added one NA in the values. |
||
result = df.convert_dtypes() | ||
tm.assert_frame_equal(df, result) |
Uh oh!
There was an error while loading. Please reload this page.