Skip to content

TYP: check_untyped_defs core.arrays.categorical #32097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonjayhawkins
Copy link
Member

pandas\core\arrays\categorical.py:347: error: Incompatible types in assignment (expression has type "None", variable has type "str")
pandas\core\arrays\categorical.py:1550: error: "argsort" of "ExtensionArray" gets multiple values for keyword argument "ascending"
pandas\core\arrays\categorical.py:1550: error: "argsort" of "ExtensionArray" gets multiple values for keyword argument "kind"

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Feb 19, 2020
@jbrockmendel jbrockmendel merged commit 02ac975 into pandas-dev:master Feb 19, 2020
@jbrockmendel
Copy link
Member

Thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the core.arrays.categorical branch February 20, 2020 09:38
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 20, 2020
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants