CLN: removed unused import

[ShaharNaveh]

• closes #xxxx
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

---

Not 100% sure about this, can close anytime if not a good PR

[ShaharNaveh]

I also benched marked it:

master:

In [1]: import pandas as pd                                                                                   

In [2]: %timeit pd.Period("2000-01-01", freq="D")                                                             
165 µs ± 777 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

---

PR:

In [1]: import pandas as pd                                                                                   

In [2]: %timeit pd.Period("2000-01-01", freq="D")                                                             
166 µs ± 449 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

[jbrockmendel]

i find the year-month-day-hour-minute-second ordering clearer than the alphabetical ordering. its not worth bikeshedding, which is why id discourage these for the most part

also makes it harder to see what the actual removed imports are (datetime and date, right?). That part im on board with.

[ShaharNaveh]

i find the year-month-day-hour-minute-second ordering clearer than the alphabetical ordering. its not worth bikeshedding, which is why id discourage these for the most part

Agreed, I have no idea how to enforce it with isort

also makes it harder to see what the actual removed imports are (datetime and date, right?). That part im on board with.

Correct, that's why I did it in two commits and not in one, as you an see after the removal of the unused imports what is left looks pretty ugly, so I figured I run isort on that specific import block.

[WillAyd]

Lgtm

[datapythonista]

Why is isort not complaining with the original code? Is it validating that file?

[ShaharNaveh]

Why is isort not complaining with the original code? Is it validating that file?

@datapythonista isort is not checking that file ATM, in the release of isort 5.0.0 it will begin to support .pyx files.

I think you ment flake8, and I don't know why it's not catching it (or if it's even checking.pyx files)

[WillAyd]

@datapythonista @jbrockmendel any outstanding objections?

[datapythonista]

lgtm

[jbrockmendel]

lgtm