Skip to content

TST/CLN: Clean categorical min / max tests #33512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2020
Merged

TST/CLN: Clean categorical min / max tests #33512

merged 5 commits into from
Apr 14, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Apr 13, 2020

Fixes one small error in a test, and otherwise tries to remove some code duplication

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be a definite improvement to me - thanks!

@WillAyd WillAyd added Clean Testing pandas testing functions or related to the test suite labels Apr 14, 2020
@WillAyd WillAyd added this to the 1.1 milestone Apr 14, 2020
@mroeschke mroeschke merged commit 859cf95 into pandas-dev:master Apr 14, 2020
@mroeschke
Copy link
Member

Thanks @dsaxton

@dsaxton dsaxton deleted the clean-cat-tests branch April 14, 2020 17:58
CloseChoice pushed a commit to CloseChoice/pandas that referenced this pull request Apr 20, 2020
* TST/CLN: Clean categorical min / max tests

* Clean

* Add error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants