BUG: can't concatenate DataFrame with Series with duplicate keys #33805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
jreback
requested changes
Apr 27, 2020
pandas/core/reshape/concat.py
Outdated
| except KeyError as err: | ||
| raise ValueError(f"Key {key} not in level {level}") from err | ||
| mask = level == key | ||
| if not any(mask): |
There was a problem hiding this comment.
it’s a bit more idiomatic to use .get_indexer here which handles duplicates - if u can make that work
There was a problem hiding this comment.
@jreback thanks for the review. I've looked into that, but it seems it errors with duplicates:
>>> pd.Index(['a', 'b']).get_indexer(['a'])
array([0])
>>> pd.Index(['a', 'b', 'b']).get_indexer(['a'])
---------------------------------------------------------------------------
InvalidIndexError Traceback (most recent call last)
<ipython-input-10-0a1bc1d27a1b> in <module>
----> 1 pd.Index(['a', 'b', 'b']).get_indexer(['a'])
~/pandas-dev/pandas/core/indexes/base.py in get_indexer(self, target, method, limit, tolerance)
2926
2927 if not self.is_unique:
-> 2928 raise InvalidIndexError(
2929 "Reindexing only valid with uniquely valued Index objects"
2930 )
InvalidIndexError: Reindexing only valid with uniquely valued Index objectsShould I open an issue for get_indexer first and make sure that deals with duplicates before coming back to this one?
jreback
added
Indexing
jreback
approved these changes
May 1, 2020
|
lgtm. let's merge on green. |
|
Thanks - sure, it's green now |
|
Thanks @MarcoGorelli |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
May 6, 2020
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff