REF: share code for scalar validation in datetimelike array methods #34076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…like-validators-scalar
…like-validators-scalar
I agree that we would want to improve the user-friendliness of these error messages. From that perspective, I prefer the error messages that were there before. |
gfyoung
reviewed
May 8, 2020
| f"'value' should be a '{self._scalar_type.__name__}', 'NaT', " | ||
| f"or array of those. Got '{type(value).__name__}' instead." | ||
| ) | ||
| raise TypeError(msg) |
There was a problem hiding this comment.
This message for example is a nicer, user-friendly one that would be good to keep.
…like-validators-scalar
jreback
requested changes
May 9, 2020
| @@ -760,6 +759,26 @@ def _validate_shift_value(self, fill_value): | |||
|
|
|||
| return self._unbox(fill_value) | |||
|
|
|||
| def _validate_scalar(self, value, msg: str, cast_str: bool = False): | |||
| if cast_str and isinstance(value, str): | |||
There was a problem hiding this comment.
can you add a doc-string here
…like-validators-scalar
jreback
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user-facing effect here is in the exception messages we show to users, where we may want to be more verbose than this. Thoughts @gfyoung?