TST: GH28813 test .diff() on Sparse dtype #34268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 20, 2020
| @@ -36,6 +36,14 @@ def test_diff(self, datetime_frame): | |||
| ).astype("float64") | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| # Result should be the same for sparse df, see GH28813 | |||
There was a problem hiding this comment.
Let's make a separate testing function for this test
mroeschke
reviewed
May 20, 2020
| normal = pd.DataFrame(arr) | ||
| sparse = pd.DataFrame(arr, dtype='Sparse[int]') | ||
| # we don't check dtype because one is sparse and the other isn't | ||
| tm.assert_frame_equal(normal.diff(), sparse.diff(), check_dtype=False) |
There was a problem hiding this comment.
Ideally we want to create the expected DataFrame with just the constructor:
result = sparse.diff()
expected = pd.DataFrame(...)
tm.assert_frame_equal(result, expected)
mroeschke
added
the
Testing
|
Gotcha ok. Updated the PR with your fixes |
mroeschke
approved these changes
May 21, 2020
|
Thanks @matteosantama |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAdd a quick test to confirm that .diff() function handles sparse dataframes the same way as regular dataframes.
First time making a pandas PR so comments, advice, critiques are encouraged.