Skip to content

Plotting Tables x-axis labels display #34891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

marydmit
Copy link
Contributor

Added x-axis labels on top. Adjusted figure sizes in order to have the complete table visible in the user guide.

@MarcoGorelli MarcoGorelli self-requested a review June 20, 2020 12:27
@jorisvandenbossche
Copy link
Member

@marydmit you already have an open PR for this at #34884 ?

@marydmit
Copy link
Contributor Author

Sorry, I may have done something wrong! I was working on another issue in the visualization rst, submitted a PR, then worked on the plotting tables part in the same doc. I am new to this, so not sure if this should be in the same PR or two different ones?

@MarcoGorelli
Copy link
Member

Yes, it seems that #34884 includes everything from this branch. If you intended to keep them separate, you should make sure to reset to master when you open a new branch - I usually do

git checkout -b <my new branch>
git fetch upstream master
git reset --hard upstream/master

just to be sure

For this time I think it's OK to carry on in the other PR :)

@MarcoGorelli
Copy link
Member

Closing as it's been taken forward in #34884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants