-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
REF: _cython_agg_blocks follow patterns similar to _apply_blockwise #35632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9ba0c86
REF: Avoid post-processing in blockwise op
jbrockmendel 288ca6d
REF: implement blk_func
jbrockmendel 13e9f52
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel ff61504
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 8ca83c3
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 6dc6a50
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel e265ec9
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 6b33a5c
revert unnecessary
jbrockmendel 2d1ec3c
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel dbf5592
typing
jbrockmendel 20a618d
typing fixup
jbrockmendel ee66b00
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 663f93b
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel 836c60b
define new_blocks earlier
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you type this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you type this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and move this to a higher scope (as used in both parts)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only append to it in this scope, everywhere else we set it directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is used in 3 blackes (sure you don't append and instead directly assign in the other scopes), but it is the same name. I would simply define it once, then append for each (or leave the assign for the others is ok i guess); it just is much easier to grok the fact that we are defining the same variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done+green