Skip to content

DOC: read_excel skiprows documentation matches read_csv (#36435) #36437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2020
Merged

DOC: read_excel skiprows documentation matches read_csv (#36435) #36437

merged 3 commits into from
Sep 18, 2020

Conversation

ahgamut
Copy link
Contributor

@ahgamut ahgamut commented Sep 18, 2020

Updated read_excel documentation to match read_csv for the skiprows parameter.
Changed test_read_excel_skiprows_list to test_read_excel_skiprows: now also tests read_excel with an int and a callable.

@ahgamut ahgamut changed the title updated docs for read_excel to match read_csv (#36435) DOC: read_excel skiprows documentation matches read_csv (#36435) Sep 18, 2020
@rhshadrach rhshadrach added Docs IO Excel read_excel, to_excel labels Sep 18, 2020
@Dr-Irv Dr-Irv merged commit 1b895ef into pandas-dev:master Sep 18, 2020
@Dr-Irv
Copy link
Contributor

Dr-Irv commented Sep 18, 2020

thanks @ahgamut . Nice first contribution!

@ahgamut ahgamut deleted the readexcel-skiprows branch September 18, 2020 14:02
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
…6435) (pandas-dev#36437)

* DOC: updated read_excel skiprows documentation to match read_csv (GH36435)

* TST: updated read_excel test with skiprows as int, callable (GH36435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: read_excel supports skiprows argument like read_csv, but tests and docs needed
3 participants