Skip to content

TYP/CLN: exclusions in BaseGroupBy #36559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

rhshadrach
Copy link
Member

Part of the code had exclusions as a list of hashables, change this to a set.

@rhshadrach rhshadrach added Clean Groupby Typing type annotations, mypy/pyright type checking labels Sep 22, 2020
@jreback jreback added this to the 1.2 milestone Sep 22, 2020
@jreback jreback merged commit 9e1bd7c into pandas-dev:master Sep 22, 2020
@jreback
Copy link
Contributor

jreback commented Sep 22, 2020

thanks @rhshadrach

@rhshadrach rhshadrach deleted the basegroupby_typing branch September 26, 2020 12:00
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Groupby Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants