-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: setitem with boolean mask and series as value is broken for Series with EA type #37676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b48c9da
6cf8b26
ee18953
22a6bff
88fe157
7bed804
b2efced
f471060
0fe21c6
dd8aed3
81d4d60
5eb5506
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,6 +144,22 @@ def test_setitem_boolean_td64_values_cast_na(self, value): | |
expected = Series([NaT, 1, 2], dtype="timedelta64[ns]") | ||
tm.assert_series_equal(series, expected) | ||
|
||
def test_setitem_boolean_nullable_int_types(self, any_numeric_dtype): | ||
# GH: 26468 | ||
jreback marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ser = Series([5, 6, 7, 8], dtype=any_numeric_dtype) | ||
ser[ser > 6] = Series(range(4), dtype=any_numeric_dtype) | ||
expected = Series([5, 6, 2, 3], dtype=any_numeric_dtype) | ||
tm.assert_series_equal(ser, expected) | ||
|
||
ser = Series([5, 6, 7, 8], dtype=any_numeric_dtype) | ||
ser.loc[ser > 6] = Series(range(4), dtype=any_numeric_dtype) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is the failure on 3.9 something else? https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=47857&view=logs&j=f016abb9-7827-5fa2-935a-22bd9b1477b6&t=c86edbe1-8c1d-5e5c-5b6f-d970fa4acf6d did you merge master recently? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AFAICT thats from the reduction bugfix yesterday. im troubleshooting it now There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tuesday, so not really recently, merged now |
||
tm.assert_series_equal(ser, expected) | ||
|
||
ser = Series([5, 6, 7, 8], dtype=any_numeric_dtype) | ||
loc_ser = Series(range(4), dtype=any_numeric_dtype) | ||
ser.loc[ser > 6] = loc_ser.loc[loc_ser > 1] | ||
tm.assert_series_equal(ser, expected) | ||
|
||
|
||
class TestSetitemViewCopySemantics: | ||
def test_setitem_invalidates_datetime_index_freq(self): | ||
|
Uh oh!
There was an error while loading. Please reload this page.