CLN: remove unused min_count argument in libgroupby.group_nth #37747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this have any impact to an end user? |
Good point. I think it allows the user to pass |
| @@ -603,8 +603,7 @@ def _aggregate( | |||
| ): | |||
| if agg_func is libgroupby.group_nth: | |||
| # different signature from the others | |||
| # TODO: should we be using min_count instead of hard-coding it? | |||
| agg_func(result, counts, values, comp_ids, rank=1, min_count=-1) | |||
There was a problem hiding this comment.
one alternative here is to remove the keyword from the libgroupby function.
There was a problem hiding this comment.
I went with that
Actually we don't use the min_count argument in the libgroupby function - I guess that it was put there to homogenize signatures, but now they're different anyways
arw2019
force-pushed
the
cln-_aggregate
branch
from
58992f5 to
7517480
Compare
arw2019
changed the title
arw2019
changed the title
|
thanks @arw2019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff