Skip to content

namespace consistency for test_dtype.py #37843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 15, 2020
Merged

namespace consistency for test_dtype.py #37843

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1810fa5
namespace consistency for test_dtype.py
reshamas Nov 14, 2020
a0183de
namespace inconsistency fix to test_interval.py
reshamas Nov 14, 2020
ba5229b
reverting changes to test_dtype.py
reshamas Nov 14, 2020
b5e63fd
fix flake8 error
reshamas Nov 14, 2020
33595ef
fix Interval change
reshamas Nov 14, 2020
a2bc471
adding back pd.IntervalDtype
reshamas Nov 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/tests/arithmetic/test_interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def test_compare_scalar_na(self, op, array, nulls_fixture, request):
result = op(array, nulls_fixture)
expected = self.elementwise_comparison(op, array, nulls_fixture)

if nulls_fixture is pd.NA and array.dtype != pd.IntervalDtype("int64"):
if nulls_fixture is pd.NA and array.dtype != IntervalDtype("int64"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert this change? Only pd.Interval needed changing, not pd.IntervalDtype

mark = pytest.mark.xfail(
reason="broken for non-integer IntervalArray; see GH 31882"
)
Expand Down Expand Up @@ -290,6 +290,6 @@ def test_index_series_compat(self, op, constructor, expected_type, assert_func):
def test_comparison_operations(self, scalars):
# GH #28981
expected = Series([False, False])
s = Series([pd.Interval(0, 1), pd.Interval(1, 2)], dtype="interval")
s = Series([Interval(0, 1), Interval(1, 2)], dtype="interval")
result = s == scalars
tm.assert_series_equal(result, expected)