Skip to content

Develop pre check #38663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 27, 2020
Merged

Develop pre check #38663

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2ce5e55
Add the check-no-pd-class hook
cjlynch278 Dec 23, 2020
5d9d2f0
Merge branch 'master' of https://github.com/pandas-dev/pandas into de…
cjlynch278 Dec 23, 2020
8d1b227
make check more generic
cjlynch278 Dec 23, 2020
77f143c
change instance of pd.testing in test class
cjlynch278 Dec 23, 2020
40298f8
Update .pre-commit-config.yaml
cjlynch278 Dec 23, 2020
7c6c4bf
Add wildcard to entry in pre-commit config file
cjlynch278 Dec 23, 2020
733b1ef
Add check to import test check
cjlynch278 Dec 24, 2020
8081304
Update .pre-commit-config.yaml
cjlynch278 Dec 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,11 @@ repos:
pandas/tests/io/excel/test_writers\.py|
pandas/tests/io/pytables/common\.py|
pandas/tests/io/pytables/test_store\.py$
- id: check-no-pd-class
name: check for pd class.
types: [python]
entry: pd.testing.assert_series_equal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be pd.testing.* (not exatcly sure how to do the wildcard here). cc @MarcoGorelli

Copy link
Contributor Author

@cjlynch278 cjlynch278 Dec 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, thanks for the feed back, I'll update this.

language: pygrep
- repo: https://github.com/asottile/yesqa
rev: v1.2.2
hooks:
Expand Down