-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CI: Skip numpy dev failing tests #39090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
import numpy as np | ||
import pytest | ||
|
||
from pandas.compat.numpy import is_numpy_dev | ||
from pandas.errors import PerformanceWarning | ||
|
||
import pandas as pd | ||
|
@@ -107,6 +108,7 @@ def test_drop_names(self): | |
expected = Index(["a", "b", "c"], name="first") | ||
tm.assert_index_equal(dropped.index, expected) | ||
|
||
@pytest.mark.xfail(is_numpy_dev, reason="GH#39089 Numpy changed dtype inference") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can u add an issue number to all of these (open one); we might need to backport this as well also see if u can find a linked numpy issue - this is a breaking change and might want to have them revert this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
def test_drop(self): | ||
simple = DataFrame({"A": [1, 2, 3, 4], "B": [0, 1, 2, 3]}) | ||
tm.assert_frame_equal(simple.drop("A", axis=1), simple[["B"]]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this import should be in the prior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean we should be able to import this from pandas.compat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok will pull the function up then so that we can import from there too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this?
Should this hold true for every other function defined in the numpy folder?