-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
REF: implement is_exact_match #39149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 4 commits into
pandas-dev:master
from
jbrockmendel:ref-setitem-exact-match
Jan 14, 2021
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
|
||
import numpy as np | ||
|
||
from pandas._typing import Any, AnyArrayLike | ||
from pandas._typing import Any, AnyArrayLike, ArrayLike | ||
|
||
from pandas.core.dtypes.common import ( | ||
is_array_like, | ||
|
@@ -270,6 +270,27 @@ def maybe_convert_indices(indices, n: int): | |
# Unsorted | ||
|
||
|
||
def is_exact_match(target: ArrayLike, value: ArrayLike) -> bool: | ||
""" | ||
Is setting this value into this target overwriting the entire column? | ||
|
||
Parameters | ||
---------- | ||
target : np.ndarray or ExtensionArray | ||
value : np.ndarray or ExtensionArray | ||
|
||
Returns | ||
------- | ||
bool | ||
""" | ||
return ( | ||
len(value.shape) > 0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. needed for mypy |
||
and len(target.shape) > 0 | ||
and value.shape[0] == target.shape[0] | ||
and value.size == target.size | ||
) | ||
|
||
|
||
def length_of_indexer(indexer, target=None) -> int: | ||
""" | ||
Return the expected length of target[indexer] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe is_exact_shape_match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure