Skip to content

TST: groupby of idxmax/min with mixed types #40795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 14, 2021
Merged
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions pandas/tests/frame/test_reductions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,27 @@ def test_idxmax_mixed_dtype(self):
expected = Series([0, 2, 1, 2], index=[1, 2, 3, 4])
tm.assert_series_equal(result, expected)

# with convert dtypes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a new test for this.

Could you try a parametrization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing, I'll separate them out and use parametrization

df2 = DataFrame(
{
"teamId": [100, 100, 100, 200, 200, 200],
"value": [0, 0, 0, 1, 2, 0],
}
)
df2 = df2.convert_dtypes()

result = df2.groupby("teamId").idxmax()
expected = DataFrame(
{"value": [0, 4]}, index=Index([100, 200], dtype="object", name="teamId")
)
tm.assert_frame_equal(result, expected)

result = df2.groupby("teamId").idxmin()
expected = DataFrame(
{"value": [0, 5]}, index=Index([100, 200], dtype="object", name="teamId")
)
tm.assert_frame_equal(result, expected)

def test_idxmax_dt64_multicolumn_axis1(self):
dti = date_range("2016-01-01", periods=3)
df = DataFrame({3: dti, 4: dti[::-1]})
Expand Down