Skip to content

TST: Test Loc to set Multiple Items to multiple new columns #42665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 28, 2021
Merged

TST: Test Loc to set Multiple Items to multiple new columns #42665

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
38d0502
Modified ecosystem.rst to include ibis
GYvan Jul 15, 2021
85c554c
created a test for issue #25594
GYvan Jul 22, 2021
c93cbd6
Test for issue #25594
GYvan Jul 22, 2021
4afc50b
reverted the changes
GYvan Jul 23, 2021
98047f4
Test Loc to set Multiple Items to multiple new columns - Changes Made
GYvan Jul 27, 2021
d44cdba
Test Loc to set Multiple Items to multiple new columns - Changes made…
GYvan Jul 27, 2021
4f2a69c
TST: Test Loc to set Multiple Items to multiple new columns - Changes…
GYvan Jul 27, 2021
d785568
TST: test for issue #25594 - Changes made
GYvan Jul 27, 2021
e654ace
removed the check_dtype
GYvan Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pandas/tests/indexing/test_loc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2768,3 +2768,15 @@ def test_loc_setitem_dict_timedelta_multiple_set(self):
[[Timedelta(6, unit="s"), "foo"]], columns=["time", "value"], index=[1]
)
tm.assert_frame_equal(result, expected)

def test_loc_set_multiple_items_in_multiple_new_columns(self):
# GH 25594
df = DataFrame(index=[1, 2], columns=["a"])
df.loc[1, ["b", "c"]] = [6, 7]
result = df.copy()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No result needed, just use df


expected = DataFrame(index=[1, 2], columns=["a", "b", "c"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please define expected without the use of loc. You can show the result of the sequential operations too, but please use another check for this

expected.loc[1, "b"] = 6
expected.loc[1, "c"] = 7

tm.assert_frame_equal(result, expected, check_dtype=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this fail w/o the check_dtype?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as it should. The expected should have dtype object while df has dtype float in these columns