Skip to content

TST: added test for to_string when max_rows is zero (GH35394) #43300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2021
Merged

TST: added test for to_string when max_rows is zero (GH35394) #43300

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c51e96
TST: added test for to_string when max_rows is zero (GH35394)
lorenzophys Aug 30, 2021
26e7fcd
TST: code review fixes, removed redundant test and empty line
lorenzophys Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions pandas/tests/io/formats/test_to_string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,3 +315,31 @@ def test_to_string_na_rep_and_float_format(na_rep):
1 A {na_rep}"""
)
assert result == expected


@pytest.mark.parametrize(
"data,expected",
[
(
{"col1": [1, 2], "col2": [3, 4]},
" col1 col2\n0 1 3\n1 2 4",
),
(
{"col1": [0, 2, 4], "col2": [3, 4, 5]},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case seems pretty similar to the first is it really needed?

" col1 col2\n0 0 3\n1 2 4\n2 4 5",
),
(
{"col1": ["Abc", 0.756], "col2": [np.nan, 4.5435]},
" col1 col2\n0 Abc NaN\n1 0.756 4.5435",
),
(
{"col1": [np.nan, "a"], "col2": [0.009, 3.543], "col3": ["Abc", 23]},
" col1 col2 col3\n0 NaN 0.009 Abc\n1 a 3.543 23",
),
],
)
def test_to_string_max_rows_zero(data, expected):
# GH35394
result = DataFrame(data=data).to_string(max_rows=0)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this blank line

assert result == expected