Skip to content

CLN: use numpy quantile in qcut #43991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Oct 12, 2021

The quantile function in algos is a partial implementation of the numpy quantile and there are no pandas objects involved.

@fangchenli fangchenli marked this pull request as draft October 12, 2021 04:53
@fangchenli fangchenli marked this pull request as ready for review October 12, 2021 12:31
@jreback jreback added this to the 1.4 milestone Oct 12, 2021
@jreback jreback added the Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff label Oct 12, 2021
@jreback jreback merged commit 1d74b3e into pandas-dev:master Oct 12, 2021
@jreback
Copy link
Contributor

jreback commented Oct 12, 2021

nice!

@fangchenli fangchenli deleted the np-quantile branch October 12, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Clean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants