MAINT: Correct small cast issues on Windows #43995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
force-pushed
the
windows-type-clean-cython
branch
2 times, most recently
from
08f9a85 to
d530f92
Compare
Use correct types to avoid downcasts on Windows
bashtage
force-pushed
the
windows-type-clean-cython
branch
from
d530f92 to
be18b40
Compare
jreback
added
the
Compat
|
avoids build warnings? |
|
Yes for some casts. Others are places where 54 but it's are being truncated to 32 bits. Would only ever show up on windows 64 in a frame with more then 2**32 rows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use correct types to avoid downcasts on Windows